Skip to content

Typed constants in Intl extenstion #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2023
Merged

Typed constants in Intl extenstion #12360

merged 6 commits into from
Oct 29, 2023

Conversation

jorgsowa
Copy link
Contributor

@jorgsowa jorgsowa commented Oct 4, 2023

This PR adds types to the constants in Intl extension.

@jorgsowa jorgsowa requested a review from kocsismate as a code owner October 4, 2023 20:50
@jorgsowa jorgsowa mentioned this pull request Oct 14, 2023
Merged
@kocsismate
Copy link
Member

Can you please rebase to fresh master? The Windows CI job doesn't work now, and hopefully a rebase will fix it 🤔

@jorgsowa jorgsowa force-pushed the typed-constant-in-intl-extension branch from 66fc7ac to 18798a3 Compare October 28, 2023 19:14
@jorgsowa
Copy link
Contributor Author

Rebase done, the same for another PR for constants typing. 👍🏾

@kocsismate kocsismate merged commit 9ad7844 into php:master Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgsowa @kocsismate